Repository navigation
fix(filter): find HasConversion by the property path - #198
Merged
Merged
Conversation
#169 found the conversion by the property path only where v1.14.2 threw. This change uses the property path for every HasConversion lookup, so a query name no longer changes how a converted property is filtered. A number, an enum, or a Guid is read by its own type, also without a query name. Before this change, that filter threw. Behavior change: a null literal on a converted reference type matches null rows. A child path such as Email.Value on a converted parent with a query name compares the parent, like without a query name. A converted Guid gives a Guid constant in the expression text, and the rows are the same. Examples (Email has HasConversion to string): Email == null before: compares with new EmailAddress("null"), 0 rows after: compares with null, rows with a null Email Email.Value == "a@x.com" (Email has a query name) before: x.Email.Value == "a@x.com" after: x.Email == new EmailAddress("a@x.com"), like without a query name Number == 2 (Number is an int with HasConversion<string>() and no query name) before: ParsingException, inner InvalidOperationException: The binary operator Equal is not defined for the types 'System.Int32' and 'System.String'. after: compares the int, 1 row From #153 on v2.
IngbertPalm
pushed a commit
to IngbertPalm/QueryKit
that referenced
this pull request
Oct 21, 2026
Sync the fork with the resynced upstream (34 commits) and keep the local "Support array literals for converted properties" change on top of it. Conflict in QueryKit/FilterParser.cs: - Upstream pdevito3#198 merged the HasConversion lookup by query name and by property path into one branch and removed the else-if fallback and CreateStringConversionRightExpr. Took that structure and re-attached the in/not-in array handling (IsArrayLiteral, CreateStringConversionArrayExpr) in front of the inline null handling of the remaining branch. - Split array items with SplitListItems instead of Split(','), so a comma inside a quoted item (upstream pdevito3#142) stays in the item. Added a unit test for it. Unit tests (775) and integration tests (393) pass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#169 found the conversion by the property path only where v1.14.2 threw. This change uses the property path for every HasConversion lookup, so a query name no longer changes how a converted property is filtered. A number, an enum, or a Guid is read by its own type, also without a query name. Before this change, that filter threw.
Behavior change: a null literal on a converted reference type matches null rows. A child path such as Email.Value on a converted parent with a query name compares the parent, like without a query name. A converted Guid gives a Guid constant in the expression text, and the rows are the same.
Examples (Email has HasConversion to string):
Email == null
before: compares with new EmailAddress("null"), 0 rows
after: compares with null, rows with a null Email
Email.Value == "a@x.com" (Email has a query name)
before: x.Email.Value == "a@x.com"
after: x.Email == new EmailAddress("a@x.com"), like without a query name
Number == 2 (Number is an int with HasConversion() and no query name)
before: ParsingException, inner InvalidOperationException: The binary operator Equal is not defined for the types 'System.Int32' and 'System.String'.
after: compares the int, 1 row
From #153 on v2.